-
Notifications
You must be signed in to change notification settings - Fork 58
Add support for Gradle 7 projects #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Task --- In Gradle 7, build fails because private fields are annotated with `@Internal` but don't have any getters. Solution --- Add getters and setters to the fields marked with `@Internal`. This is consistent with other fields marked as `@Internal` in `ApolloClassGenTask`
I was trying to fix this by having a custom build of the plugin but it got too complicated to build it along with the project. We would love to have this be available ASAP in the original plugin and in the repo, since this is becoming a blocker for our project. |
Bump for whoever is maintaining this. We need you! |
This is holding us up being able to use Jetpack Compose, we would love if it could be merged 🙏 |
Hi, same thing here, we need this ASAP. |
please , we need this update soo urgent , can you push the fix |
+1, would love to this merged in and a release made. This is a big blocker for us. |
🙇 |
Any release planned @rjuliano? |
I don't want to be harsh, but come on... We are all using a commercial solution here and we depend on these SDKs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1, for me this is really a blocker, a new version of the navigation component, which added fixes for push notifications on android 12, only works with gradle 7. |
@mukovozov My PR doesn't fix Gradle 7 compatibility. I'm having another error at compile time and I'm working on another patch to compile on Gradle 7. |
Execution failed for task ':app:nodeSetup'.
|
Issue #, if available:
#360
Description of changes:
Task
In Gradle 7, build fails because private fields are annotated with
@Internal
but don't have any getters.Solution
Add getters and setters to the fields marked with
@Internal
.This is consistent with other fields marked as
@Internal
inApolloClassGenTask
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.