Skip to content

Add support for Gradle 7 projects #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

baksansk
Copy link
Contributor

@baksansk baksansk commented Aug 8, 2021

Issue #, if available:
#360

Description of changes:

Task

In Gradle 7, build fails because private fields are annotated with @Internal but don't have any getters.

Solution

Add getters and setters to the fields marked with @Internal.
This is consistent with other fields marked as @Internal in ApolloClassGenTask

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Task
---
In Gradle 7, build fails because private fields are annotated with `@Internal` but don't have any getters.

Solution
---
Add getters and setters to the fields marked with `@Internal`.
This is consistent with other fields marked as `@Internal` in `ApolloClassGenTask`
@IgorCordasEndava
Copy link

IgorCordasEndava commented Aug 18, 2021

I was trying to fix this by having a custom build of the plugin but it got too complicated to build it along with the project.
Your changes look good and they would fix the issue.

We would love to have this be available ASAP in the original plugin and in the repo, since this is becoming a blocker for our project.

@TomBell-Trove
Copy link

Bump for whoever is maintaining this. We need you!

@HarrisonSeidel
Copy link

This is holding us up being able to use Jetpack Compose, we would love if it could be merged 🙏

@lolucosmin
Copy link

Hi, same thing here, we need this ASAP.

@thegamer123
Copy link

please , we need this update soo urgent , can you push the fix

@jimmyhoran
Copy link

+1, would love to this merged in and a release made. This is a big blocker for us.

@rjuliano rjuliano merged commit b59540b into awslabs:main Oct 12, 2021
@TomBell-Trove
Copy link

🙇

@somq
Copy link

somq commented Oct 15, 2021

Any release planned @rjuliano?
Waiting on this one to bump our gradle version

@somq
Copy link

somq commented Oct 28, 2021

I don't want to be harsh, but come on... We are all using a commercial solution here and we depend on these SDKs.
I'm aware that maintainers have a schedule forced by the time they can affect to the project but generally speaking AWS need to be wayyy more reactive, especially concerning these blocking updates.

Copy link

@poojamat poojamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukovozov
Copy link

+1, for me this is really a blocker, a new version of the navigation component, which added fixes for push notifications on android 12, only works with gradle 7.

@baksansk
Copy link
Contributor Author

@mukovozov My PR doesn't fix Gradle 7 compatibility. I'm having another error at compile time and I'm working on another patch to compile on Gradle 7.

@itslonua
Copy link

Execution failed for task ':app:nodeSetup'.

Build was configured to prefer settings repositories over project repositories but repository 'ivy' was added by unknown code

  • Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

@poojamat poojamat mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.