Skip to content

Fixing issues #115 and #161 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

stefanofornari
Copy link
Contributor

@stefanofornari stefanofornari commented Sep 14, 2023

Issue #, if available:
This PR covers issue #115 and #161

S3 compatible services like minio do not like AWS S3 virtual-style addressing, where the bucket name is considered part of the hostname (e.g. pippo -> pippo.s3.eu-central-1.amazonaws.com).
We therefore set the path-style addressing by default for s3x provider, while we also give the possibility to configure it via the s3.spi.force-path-style.

I took this opportunity to make some improvements to the readme about the different configuration parameters. Please have a look and let me know if you like it.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markjschreiber
Copy link
Contributor

@stefanofornari there is a version conflict in this PR. This may be due to the order in which I merged your other PR? Can you resolve the conflict and then we can get these changes into the next release.

@stefanofornari
Copy link
Contributor Author

@stefanofornari there is a version conflict in this PR. This may be due to the order in which I merged your other PR? Can you resolve the conflict and then we can get these changes into the next release.

I should have done

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this PR but I am wondering if there is a way to only force path style for S3x URIs? Path style requests are being retired from S3. Could the default be to not force path style but to allow that to be configured?

https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore my last comment. I missed that force path style isn't actually the default.

@markjschreiber markjschreiber merged commit 35b23cd into awslabs:main Sep 19, 2023
@stefanofornari stefanofornari deleted the upstream-main#115 branch November 7, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants