Skip to content

Reduce Max Message Size to 24MB #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Reduce Max Message Size to 24MB #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions include/aws/event-stream/event_stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@
AWS_PUSH_SANE_WARNING_LEVEL

#define AWS_C_EVENT_STREAM_PACKAGE_ID 4
/* max message size is technically unbounded on the client side, and validated on the server side but we don't want to
* allocate large buffers in case of bugs. 256 MB is a reasonably large buffer size limit. Current service-
* side max is 24 MB, likely to increase in future.
/* Current service-side max is 24 MB, likely to increase in future.
* This is encoded on the wire in 4 bytes, and could technically be larger (up to INT32_MAX). */
#define AWS_EVENT_STREAM_MAX_MESSAGE_SIZE (256 * 1024 * 1024)
#define AWS_EVENT_STREAM_MAX_MESSAGE_SIZE (24 * 1024 * 1024)

/* Max total size for headers.
* This is encoded on the wire in 4 bytes, and could technically be larger (up to INT32_MAX). */
Expand Down