Skip to content

Add release workflow for litani #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Conversation

ronakfof
Copy link
Contributor

@ronakfof ronakfof commented Feb 3, 2022

Tests
Example Release - [workflow]
Deb package - [workflow]
Example PR to tap - [workflow]

Description of changes:

This workflow gets triggered when a tag is pushed of format litani-*.
Bot creates a release for that tag with a boilerplate description.
If a release is created successfully, it also creates a debian package for Litani on ubuntu-20.04, tests it and uploads it as an additional asset to the release and also create a PR to aws/tap with updated version, tag and commit.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ronakfof ronakfof force-pushed the release-workflow branch 3 times, most recently from 3b266aa to 216ca49 Compare February 6, 2022 04:34
Copy link
Contributor

@karkhaz karkhaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this. My main question is whether we can integrate the changelog into the release notes.

Maybe the right thing to do here is: instead of this workflow triggering on litani-* tag, it would trigger on any commit that gets pushed with an updated changelog. In that case, it would take the release notes from the changelog, and the workflow itself would create the release tag.

So from a user perspective, when we want to create a new release, we add to the CHANGELOG and push that change to the develop branch, and this workflow would merge the release branch into that commit and tag it as the next release.

That might be more complicated though because the workflow itself would have to figure out the release number... But I'm quite keen for the release notes to end up in the tag message.

@ronakfof ronakfof force-pushed the release-workflow branch 4 times, most recently from c9fd030 to 94273dc Compare February 9, 2022 16:06
@ronakfof ronakfof force-pushed the release-workflow branch 2 times, most recently from d2bd96b to 931433c Compare February 10, 2022 20:05
@ronakfof ronakfof requested a review from angelonakos February 10, 2022 22:07
Copy link
Contributor

@karkhaz karkhaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome :)

@ronakfof ronakfof merged commit 590877b into awslabs:develop Feb 11, 2022
@ronakfof ronakfof deleted the release-workflow branch February 17, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants