Skip to content

Terminating Litani is not reliable #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
karkhaz opened this issue May 19, 2022 · 0 comments
Open

Terminating Litani is not reliable #162

karkhaz opened this issue May 19, 2022 · 0 comments
Labels
critical difficult

Comments

@karkhaz
Copy link
Contributor

karkhaz commented May 19, 2022

@markrtuttle @nwetzler report that some subprocesses of ninja persist when sending SIGTERM to litani-run-build. Going to try reproducing now
karkhaz added a commit to karkhaz/aws-build-accumulator that referenced this issue Jun 12, 2022
@karkhaz
Correctly handle signals TERM, INT, and HUP
2506e56 
`litani run-build` now makes ninja the leader of its own process group.
This allows run-build to forward signals to that entire process group,
so that ninja and all its descendants receive the signal. This ensures
that when users press Ctrl-C on Litani's controlling terminal, the INT
is propagated to the commands in each Litani job.

This fixes awslabs#162.
karkhaz added a commit to karkhaz/aws-build-accumulator that referenced this issue Jun 12, 2022
@karkhaz
Correctly handle signals TERM, INT, and HUP
94440c0 
`litani run-build` now makes ninja the leader of its own process group.
This allows run-build to forward signals to that entire process group,
so that ninja and all its descendants receive the signal. This ensures
that when users press Ctrl-C on Litani's controlling terminal, the INT
is propagated to the commands in each Litani job.

This fixes awslabs#162.
karkhaz added a commit to karkhaz/aws-build-accumulator that referenced this issue Jun 13, 2022
@karkhaz
Correctly handle signals TERM, INT, and HUP
97f06a0 
`litani run-build` now makes ninja the leader of its own process group.
This allows run-build to forward signals to that entire process group,
so that ninja and all its descendants receive the signal. This ensures
that when users press Ctrl-C on Litani's controlling terminal, the INT
is propagated to the commands in each Litani job.

This fixes awslabs#162.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical difficult
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karkhaz