Skip to content

Daveisfera pr 397 #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Daveisfera pr 397 #421

merged 5 commits into from
Dec 6, 2023

Conversation

sirknightj
Copy link
Contributor

@sirknightj sirknightj commented Dec 5, 2023

#394 / #397, with some small modifications + running the tests

  1. Use IS_EMPTY_STRING macro from PIC
  2. Use the maximum lengths defined in https://docs.aws.amazon.com/kinesisvideostreams/latest/dg/limits.html#limits-streaming-metadata instead of arbitrary 200 (which goes past 128 for key length).
  3. Use SNPRINTF macro from PIC instead of sprintf.
  4. Update the README.

Manual tests:

  • ./kvsVideoOnlyRealtimeStreamingSample test-stream h264 "" ../samples 0 -- works ✅

  • ./kvsVideoOnlyRealtimeStreamingSample test-stream h264 "" ../samples 11 -- errors and exits ✅

  • ./kvsVideoOnlyRealtimeStreamingSample test-stream h264 "" ../samples 9 -- works ✅

  • See the mkv tags appended using mkvinfo. Procedure:

export KVS_DEBUG_DUMP_DATA_FILE_DIR=`pwd`/media
mkdir media
./kvsVideoOnlyRealtimeStreamingSample test-stream
mkvinfo -v ./media/test-stream_0.mkv
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdelapla
Copy link
Contributor

jdelapla commented Dec 5, 2023

Add instructions to README.md for new arguments.

@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (4f1e798) 62.83% compared to head (ef275ac) 62.76%.

❗ Current head ef275ac differs from pull request most recent head 27d593b. Consider uploading reports for the commit 27d593b to get more accurate results

Files Patch % Lines
samples/KvsVideoOnlyRealtimeStreamingSample.c 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #421      +/-   ##
===========================================
- Coverage    62.83%   62.76%   -0.08%     
===========================================
  Files           32       32              
  Lines         4599     4611      +12     
===========================================
+ Hits          2890     2894       +4     
- Misses        1709     1717       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdelapla jdelapla merged commit 83c31c3 into develop Dec 6, 2023
@sirknightj sirknightj deleted the daveisfera-pr-397 branch December 6, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants