Manage MCP Servers #330
Merged
Manage MCP Servers #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervers # Conflicts: # lib/user-interface/react/package.json # package-lock.json
# Conflicts: # test/lambda/test_repository_lambda.py
jmharold
reviewed
Jun 24, 2025
batzela
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
You are getting Items from the response and verifying it exists in a few places. Why don't you pull this logic out?
from option import Option
def get_item(response, mcp_server_id):
return Option.from_nullable(next(iter(response.get("Items", [])), None)).expect(
f"MCP Server {mcp_server_id} not found."
)
jmharold
approved these changes
Jun 24, 2025
jmharold
reviewed
Jun 24, 2025
| if (isCreatingError || isUpdatingError) { | ||
| const verb = isCreatingError ? 'created' : 'updated'; | ||
| const error = createError || updateError; | ||
| notificationService.generateNotification(`Error ${verb} MCP Server: ${error.data?.message ?? error.data}`, 'error'); |
There was a problem hiding this comment.
Error notification should be updated to "MCP Connection" similar to success notification above
jmharold
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.