Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource validator using schema models #2917

Merged
merged 8 commits into from
Feb 21, 2023

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Feb 16, 2023

Issue #, if available

Description of changes

Use models from SAM schema for property validation.

Description of how you validated changes

Added unit tests and all tests passed

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner February 16, 2023 23:07
@GavinZZ GavinZZ marked this pull request as draft February 16, 2023 23:07
@GavinZZ GavinZZ force-pushed the resource_validation branch from bfbe3de to 1ee4445 Compare February 16, 2023 23:29
@GavinZZ GavinZZ marked this pull request as ready for review February 16, 2023 23:31
@GavinZZ GavinZZ force-pushed the resource_validation branch from 463b927 to ff85aa5 Compare February 17, 2023 21:31
@GavinZZ GavinZZ requested review from hoffa and aahung February 17, 2023 21:33
@GavinZZ GavinZZ force-pushed the resource_validation branch from af47f2a to 1662e0b Compare February 18, 2023 00:24
@hoffa
Copy link
Contributor

hoffa commented Feb 18, 2023

🎉

@GavinZZ GavinZZ merged commit e5173c2 into aws:develop Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants