Skip to content

ci: mypy/pylint/format schema_source package #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2023
Merged

ci: mypy/pylint/format schema_source package #2828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ integ-test:
pytest --no-cov integration/*

black:
black setup.py samtranslator/* tests/* integration/* bin/*.py
black setup.py samtranslator/* tests/* integration/* bin/*.py schema_source
bin/json-format.py --write tests integration samtranslator/policy_templates_data
bin/yaml-format.py --write tests
bin/yaml-format.py --write integration --add-test-metadata
Expand All @@ -29,16 +29,16 @@ black-check:
python -m schema_source.schema --sam-schema .tmp/sam.schema.json --cfn-schema schema_source/cloudformation.schema.json --unified-schema .tmp/schema.json
diff -u schema_source/sam.schema.json .tmp/sam.schema.json
diff -u samtranslator/schema/schema.json .tmp/schema.json
black --check setup.py samtranslator/* tests/* integration/* bin/*.py
black --check setup.py samtranslator/* tests/* integration/* bin/*.py schema_source
bin/json-format.py --check tests integration samtranslator/policy_templates_data
bin/yaml-format.py --check tests
bin/yaml-format.py --check integration --add-test-metadata

lint:
# mypy performs type check
mypy --strict samtranslator bin
mypy --strict samtranslator bin schema_source
# Linter performs static analysis to catch latent bugs
pylint --rcfile .pylintrc samtranslator
pylint --rcfile .pylintrc samtranslator schema_source
# cfn-lint to make sure generated CloudFormation makes sense
bin/run_cfn_lint.sh

Expand Down