chore: Move schema source/generation out of samtranslator package #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahung
force-pushed
the
move-schema-src-out-of-samtranslator-package
branch
from
ab12fd0 to
ed24a5d
Compare
hoffa
reviewed
Jan 27, 2023
aahung
force-pushed
the
move-schema-src-out-of-samtranslator-package
branch
from
ed24a5d to
4616b5a
Compare
hoffa
reviewed
Jan 27, 2023
aahung
force-pushed
the
move-schema-src-out-of-samtranslator-package
branch
from
4616b5a to
eb359a8
Compare
aahung
force-pushed
the
move-schema-src-out-of-samtranslator-package
branch
from
eb359a8 to
fe6899b
Compare
hoffa
approved these changes
Jan 27, 2023
ssenchenko
approved these changes
Jan 27, 2023
|
As a result of this PR, serverless-application-model/setup.py Line 62 in 480be09 |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
The generated schema files stay in
samtranslator/schema, everything else moved toschema_source.This removes
pydanticfrom our pypi requirementDescription of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.