Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor ImplicitHttpApiPlugin and ImplicitRestApiPlugin #2784

Merged
merged 3 commits into from
Jan 14, 2023

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Jan 13, 2023

Issue #, if available

Description of changes

  • combine duplicate code or similar code
  • convert to constants if something is constant
  • add types
  • correct variable namings
  • use generic classes

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung requested a review from a team as a code owner January 13, 2023 23:29
@aahung aahung enabled auto-merge (squash) January 13, 2023 23:30
@aahung aahung force-pushed the refactor-20230113 branch from 002a323 to e945fc6 Compare January 13, 2023 23:38
Copy link
Contributor

@acristin acristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aahung aahung merged commit bf998cf into aws:develop Jan 14, 2023
@aahung aahung deleted the refactor-20230113 branch January 14, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants