refactor: implement match the same for all pkeys #5224
Merged
+317
−275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
commented
Mar 28, 2025
There was a problem hiding this comment.
This isn't a new test, I just renamed it. Previously this test was called s2n_pkey_test. I can't seem to communicate that to github :(
This test does technically test s2n_pkey_match, but in a non-obvious way. s2n_cert_chain_and_key_load_pem calls s2n_pkey_match while loading the certificate. But since this is a unit test, we should really be calling s2n_pkey_match directly. What if we changed the implementation of s2n_cert_chain_and_key_load_pem so that s2n_pkey_match isn't called?
I renamed this test rather than delete it bc I don't think it's doing any harm, but I can always just delete it instead.
lrstewart
force-pushed
the
openssl3fips_evp_3c_1
branch
2 times, most recently
from
03e1e9a to
f38bc40
Compare
lrstewart
force-pushed
the
openssl3fips_evp_3c_1
branch
from
f38bc40 to
df618e2
Compare
jmayclin
approved these changes
Apr 1, 2025
boquan-fang
approved these changes
Apr 1, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
related to #5149
Description of changes:
Step one of cleaning up the legacy pkey logic: move the
matchmethod out of the individual pkey implementations and into the main shared logic.matchshould always be implemented the same, rather than each implementation re-writing the same sign/verify logic.Call-outs:
RSA-PSS was doing some additional validation, not just sign/verify. However, I don't believe that logic is necessary if we're going to sign/verify anyway. Seems unnecessary. But let me know if you think I'm missing something that makes it necessary / useful.
Testing:
Added a new unit test. Future PRs will add more tests to the new s2n_pkey_test file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.