feat(s2n-quic-transport) Adds packet storage feature #2668
+285
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
force-pushed
the
packet_storage
branch
from
6c0bc2e to
db09fd7
Compare
maddeleine
force-pushed
the
packet_storage
branch
from
db09fd7 to
99a18b1
Compare
maddeleine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Optional feature for s2n-quic to buffer packets it cannot decrypt until the keys to decrypt them are generated. This potentially allocates more memory per connection but it also combats packet loss.
Resolved issues:
resolves #2601
Description of changes:
s2n-quic will currently throw out packets it can't decrypt. We want to buffer at least one per packet space so that if the TLS library returns pending we store the packet until we can decrypt it.
Call-outs:
Testing:
Includes changes to the slow_tls test to assert that with this feature we are as fast as a normal TLS handshake since we are now buffering packets that were previously dropped.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.