feat: port listDirectory from VSC #930
Merged
+172
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmile
reviewed
Apr 8, 2025
| this.workspace = features.workspace | ||
| } | ||
|
|
||
| public async queueDescription(params: ListDirectoryParams, updates: WritableStream) { |
There was a problem hiding this comment.
What, if anything, will call this method?
There was a problem hiding this comment.
In the VSC implementation they use this to stream directly to chat. AFAIK there isn't a current implementation of this yet in Flare, but left this existing logic here to make it easier to port once it is, since it may simply involve moving this method elsewhere.
kmile
reviewed
Apr 8, 2025
| agent.addTool(fsReadTool.getSpec(), (input: FsReadParams) => fsReadTool.invoke(input)) | ||
|
|
||
| agent.addTool(fsWriteTool.getSpec(), (input: FsWriteParams) => fsWriteTool.invoke(input)) | ||
|
|
||
| agent.addTool(listDirectoryTool.getSpec(), (input: ListDirectoryParams) => listDirectoryTool.invoke(input)) |
There was a problem hiding this comment.
Is this where we could include queueDescription if we needed rich output in the tool invocation?
There was a problem hiding this comment.
Likely, there appears to be some custom logic built around how this is invoked that will likely have to be moved within these invoke methods.
kmile
approved these changes
Apr 8, 2025
opieter-aws
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
reliant on changes in #923
This tool is currently in VSC and should live in Flare.
Solution
FsToolsServer.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.