Skip to content

fix: remove loading when stop clicked and add loading when request in… #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

zixlin7
Copy link
Contributor

@zixlin7 zixlin7 commented Apr 24, 2025

… progress

Problem

  • the initial thinking doesn't go away if you click stop button
  • no thinking between iterations of requests

Solution

  • in onStopChatResponse, if item type is AnswerStream update the item type to Answer
  • add loading messages to the duration that we are preparing request and receive response from api

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zixlin7 zixlin7 requested a review from a team as a code owner April 24, 2025 17:11
@zixlin7 zixlin7 marked this pull request as draft April 24, 2025 17:12
@zixlin7 zixlin7 force-pushed the stop branch 4 times, most recently from bb246f1 to 4c54fda Compare April 24, 2025 18:05
@zixlin7 zixlin7 marked this pull request as ready for review April 24, 2025 18:08
@zixlin7 zixlin7 merged commit 40098dd into aws:main Apr 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants