feat: add ide category to auto-trigger threshold computation #1104
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JB and VSC need different IDE cofficients for auto trigger threshold
server/aws-lsp-codewhisperer/src/language-server/inline-completion/codeWhispererServer.ts
Outdated
Show resolved
Hide resolved
other IDE's value should be 0
jpinkney-aws
approved these changes
Apr 25, 2025
volodkevych
reviewed
Apr 29, 2025
| 'AmazonQ-For-VSCode': 'VSCODE', | ||
| 'Amazon-Q-For-JetBrains': 'JETBRAINS', | ||
| 'Amazon Q For JetBrains': 'JETBRAINS', |
There was a problem hiding this comment.
What is this inconsistency caused by? Cannot we pass extension name for JetBrains in clientInfo following the same format as for other IDEs?
There was a problem hiding this comment.
The extension name for JetBrains is "Amazon Q For JetBrains", with spaces, not sure why the version with hyphens are added there, this is tested with Jb talking to flare,
For Eclipse and VS, they should be already talking to flare so assuming the names are correct, for VSC I'm not sure, it will be determined when we decide to move VSC inline to flare.
volodkevych
reviewed
Apr 29, 2025
server/aws-lsp-codewhisperer/src/language-server/inline-completion/codeWhispererServer.ts
Outdated
Show resolved
Hide resolved
volodkevych
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JB and VSC need different IDE cofficients for auto trigger threshold
Problem
JB and VSC need different IDE cofficients for auto trigger threshold
Solution
Pass IDE category as the parameter and get different coefficient based on this info
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.