-
Notifications
You must be signed in to change notification settings - Fork 1.1k
perf: Add Get()
on InstanceType provider
#8118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Add Get()
on InstanceType provider
#8118
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
9b16fa6
to
8bfa16b
Compare
Get()
on InstanceType provider
Pull Request Test Coverage Report for Build 15202516228Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
8bfa16b
to
d9de17c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
Improve performance on List() NodeClaims on the cloudprovider by not resolving all instance types every single iteration across the instance types.
How was this change tested?
make presubmit
/karpenter snapshot
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.