-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor: instance profile provider #7971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Snapshot successfully published to
|
Pull Request Test Coverage Report for Build 14258112541Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
Refactors the instance profile provider to introduce a
Get
method and take the instance profile name, role name, and tags directly in create / delete.How was this change tested?
make presubmit
+/karpenter snapshot
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.