-
Notifications
You must be signed in to change notification settings - Fork 1.1k
test: Add e2etests for checking metrics #7915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8c399f4
to
9c17d21
Compare
✅ Deploy Preview for karpenter-docs-prod canceled.
|
9c17d21
to
938c869
Compare
✅ Deploy Preview for karpenter-docs-prod canceled.
|
938c869
to
4a2611c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Pull Request Test Coverage Report for Build 13934307754Details
💛 - Coveralls |
Snapshot successfully published to
|
07f54c6
to
d7c9b15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
d7c9b15
to
f891e80
Compare
2c18f7c
to
f710962
Compare
f710962
to
b37daac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
Add e2etests for validating that a minimum number of metrics are returned back from Karpenter. This would have prevented the regression that was fixed in #7877.
The testing port-forwards the pods and directly hits their metrics endpoints, parsing the metrics, and ensuring the count of metrics is over a certain amount (which is estimated from the number of instance types/subnets that we support).
How was this change tested?
make presubmit
/karpenter snapshot
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.