Skip to content

fix: update RunInstances permissions for capacity-reservations #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Feb 26, 2025

Fixes #N/A

Description
Updates the resources scoping for RunInstances to include capacity reservations and unpins from my fork.

How was this change tested?
make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner February 26, 2025 16:02
@jmdeal jmdeal requested a review from tzneal February 26, 2025 16:02
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 7665943
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67bf3c48ed2ee20007ad9a40

engedaam
engedaam previously approved these changes Feb 26, 2025
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal enabled auto-merge (squash) February 26, 2025 16:08
@jmdeal jmdeal merged commit 059d85e into aws:main Feb 26, 2025
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13548146218

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.771%

Totals Coverage Status
Change from base Build 13548016871: 0.0%
Covered Lines: 6639
Relevant Lines: 9943

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13548262499

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.771%

Totals Coverage Status
Change from base Build 13548016871: 0.0%
Covered Lines: 6639
Relevant Lines: 9943

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants