Use Aspire 9's WaitFor feature for making projects wait for CloudFormation #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation resource to be in ready state.
ghost
approved these changes
Jan 22, 2025
philasmar
approved these changes
Jan 22, 2025
| "Name": "Aspire.Hosting.AWS", | ||
| "Type": "Patch", | ||
| "ChangelogMessages": [ | ||
| "Use Aspire 9\u0027s WaitFor mechanism for waiting CloudFormation resource to be running" |
There was a problem hiding this comment.
nit: you might want to remove the unicode char since that's how it'll look in the changelog
There was a problem hiding this comment.
Removed the Unicode character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
To be consistent with other Aspire integrations use the
WaitFormechanism added in Aspire 9 for forcing projects to wait till CloudFormation is ready. This is a switch from the homegrown solution of using our ownTaskCompletionSourceto force a block in the project resource.The
TaskCompletionSourceis still used in other parts of the integration, specifically the publicGetValueAsyncAPI for aStackOutputReferenceso the code still exist but for the common case of having the project reference the stack the experience will be consistent with other integrations.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.