feat(amazonq): Handle disclaimer acknowledgement #6825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinmk3
reviewed
Mar 31, 2025
| @@ -34,13 +34,14 @@ export class AmazonQChatViewProvider implements WebviewViewProvider { | |||
| } | |||
|
|
|||
| const uiPath = webviewView.webview.asWebviewUri(Uri.parse(this.mynahUIPath)).toString() | |||
| webviewView.webview.html = getWebviewContent(uiPath) | |||
| const disclaimerAcknowledged = globals.globalState.tryGet('aws.amazonq.disclaimerAcknowledged', Boolean, false) | |||
There was a problem hiding this comment.
Should this not be stored in suppressPrompts ?
There was a problem hiding this comment.
this is just porting the existing implementation to the lsp one. Maybe originally yes, but now that's going to require all sorts of extra re-working to port the global state to suppress prompts
There was a problem hiding this comment.
that's going to require all sorts of extra re-working to port the global state to suppress prompts
If we don't "port global state", is the worst case that an extra dialog is shown one time, which can be dismissed? Or is there some other problem I am missing?
There was a problem hiding this comment.
No, its mostly that. It's just going to be annoying for users. I've set it up so that if they had previous acknowledged it it moves it to supress prompts instead
jpinkney-aws
force-pushed
the
lsp-disclaimer
branch
from
195e365 to
972f150
Compare
jpinkney-aws
added a commit
that referenced
this pull request
Apr 2, 2025
#6912) ## Problem [sessionManager](https://github.com/aws/aws-toolkit-vscode/blob/master/packages/amazonq/src/app/inline/sessionManager.ts#L6) has an implicit dependency on `@aws/language-server-runtimes-types` that isn't present in the package.json ## Solution Add an explicit dependency, that way when the underling package currently controlling runtime-types's version changes it doesn't cause a build error as current observed in #6825 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
jpinkney-aws
force-pushed
the
lsp-disclaimer
branch
3 times, most recently
from
c00d616 to
b02e418
Compare
justinmk3
approved these changes
Apr 2, 2025
jpinkney-aws
force-pushed
the
lsp-disclaimer
branch
from
b02e418 to
72bca8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.