-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdkv3): centralize and improve client logging and error handling. #6780
Open
Hweinstock
wants to merge
13
commits into
aws:master
Choose a base branch
from
Hweinstock:sdkv3/perfLogging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+203
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4fc4fd9
to
49ce3fa
Compare
49ce3fa
to
e90c374
Compare
/runIntegrationTests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
call
functionality should be available to other clients.call
logged performance and header information on failures, and allowed for silent failure with fallback values.<Error>.code
is no longer reliably defined.Solution
call
implementation in CodeCatalyst to live withinmakeRequest
, such that failures in the genericClientWrapper
log performance and allow fallback values.code
, thenCode
, then fallback toname
. Noticed some errors includedCode
, but not all.Examples
On successful api request logs:
On failing API request logs:
the
[manually-omitted]
field were removed by hand and exist in the original logs.Future Work
feature/x
branches will not be squash-merged at release time.