feat(amazonq): client-side build support #6771
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dhasani23
commented
Mar 12, 2025
| @@ -567,22 +579,21 @@ export class GumbyController { | |||
| await startTransformByQ() | |||
| } | |||
|
|
|||
| // only for Language Upgrades | |||
| private async validateBuildWithPromptOnError(message: any | undefined = undefined): Promise<void> { | |||
There was a problem hiding this comment.
This function is not needed because we can just ask the user for their source and target JDK paths each time, rather than running a shell command just to decide whether or not to prompt them.
dhasani23
commented
Mar 12, 2025
| @@ -109,37 +107,6 @@ export async function processSQLConversionTransformFormInput(pathToProject: stri | |||
| transformByQState.setTargetJDKVersion(JDKVersion.JDK17) | |||
| } | |||
|
|
|||
| async function validateJavaHome(): Promise<boolean> { | |||
There was a problem hiding this comment.
added 2 commits
March 12, 2025 10:41
dhasani23
commented
Mar 26, 2025
| const buildResultsManifest = { | ||
| capability: 'CLIENT_SIDE_BUILD', | ||
| exitCode: exitCode, | ||
| commandLogFileName: 'clientBuildLogs.log', |
There was a problem hiding this comment.
Does name of this file matter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We should perform builds client-side (rather than server-side) to handle customers’ unique / challenging local environments, which often cause our server-side build to fail.
Solution
Periodically download intermediate
diff.patchfiles, apply them to a copy of the project, perform the local build, then upload the build logs and resume the transformation.feature/xbranches will not be squash-merged at release time.