Skip to content

Add SAM executable validation to DeployServerlessApplicationDialog #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhangzhx opened this issue Nov 15, 2018 · 1 comment
Closed

Add SAM executable validation to DeployServerlessApplicationDialog #476

zhangzhx opened this issue Nov 15, 2018 · 1 comment
Assignees
@zhangzhx
Milestone
v1.1

Comments

@zhangzhx
Copy link
Contributor

We need to check whether a valid SAM executable command is configured before deploying the SAM application in the DeployServerlessApplicationDialog
@zhangzhx zhangzhx self-assigned this Nov 15, 2018
@gholt-aws gholt-aws added the Pri2 label Nov 16, 2018
@gholt-aws gholt-aws added this to the Initial Release milestone Nov 16, 2018
@gholt-aws
Copy link
Contributor

Split into two items:

  1. have a better error message
  2. take the user to the settings page where they can fix the value

@rli rli mentioned this issue Nov 19, 2018
Closed
@zhangzhx zhangzhx mentioned this issue Nov 22, 2018
Merged
9 tasks
@gholt-aws gholt-aws modified the milestones: Initial Release, R2 Nov 22, 2018
abrooksv pushed a commit that referenced this issue Nov 8, 2021
@rli
Change MDE execution role to resource selector dropdown (#476)
1f54591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangzhx zhangzhx

Labels
None yet
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@zhangzhx @gholt-aws