Skip to content

Update function code, with function built inside a container #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brunocuervo opened this issue May 2, 2020 · 4 comments
Closed

Update function code, with function built inside a container #1740

brunocuervo opened this issue May 2, 2020 · 4 comments
Labels
bug We can reproduce the issue and confirmed it is a bug.

Comments

@brunocuervo
Copy link

Your Environment

  • OS: macOS 10.15.4
  • JetBrains product: WebStorm
  • JetBrains product version: 2020.1.1
  • AWS Toolkit version: aws-cli/2.0.10 Python/3.7.4 Darwin/19.4.0 botocore/2.0.0dev14
  • SAM CLI version: SAM CLI, version 0.48.0
  • node version: v12.16.2

Question

I'm building a lambda in node that uses a native module (canvas). When running the lambda locally, I can just check the "Build function inside a container", and things are built as expected against the correct image, and not my local env. But then when I right-click the lambda and select "Update Function Code" to deploy it, it is built without the --use-container (I can see it in the sam build command), and then execution fails when I run it remotely.
Is there any way to deploy the lambda built in a container with the toolkit? Am I missing something?

@brunocuervo brunocuervo added the guidance General information and guidance, answers to FAQs, or recommended best practices/resources. label May 2, 2020
@abrooksv
Copy link
Contributor

abrooksv commented May 2, 2020

You are not missing anything, we added it to Deploy Serverless but not Update Function Code.

This was a miss on our part.

@abrooksv abrooksv added bug We can reproduce the issue and confirmed it is a bug. and removed bug We can reproduce the issue and confirmed it is a bug. guidance General information and guidance, answers to FAQs, or recommended best practices/resources. labels May 2, 2020
@hunterwerlla
Copy link
Contributor

@brunocuervo our next EAP release (which should come out tomorrow) fixes this and it will part of the next release

@brunocuervo
Copy link
Author

brunocuervo commented May 4, 2020 via email

@abrooksv
Copy link
Contributor

This was released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We can reproduce the issue and confirmed it is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants