fix: supporte moving default lists for xml parser #3087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3087 +/- ##
==========================================
+ Coverage 97.05% 97.06% +0.01%
==========================================
Files 330 330
Lines 9529 9534 +5
Branches 1750 1751 +1
==========================================
+ Hits 9248 9254 +6
+ Misses 281 280 -1
Continue to review full report at Codecov.
|
Currently for all xml service, the parser inserts empty array [] when a list member doesn't exist in xml string. It was introduced long ago: aws@eae5b32 This change introduce a new key in metadata called xmlNoDefaultLists. If set to true, xml parser will not try to insert default empty array if the member doesn't exist. This key is only applicable to rest-xml, query protocol services.
AllanZhengYP
force-pushed
the
fix-empty-member-xml
branch
from
993903d to
1974053
Compare
AllanZhengYP
force-pushed
the
fix-empty-member-xml
branch
from
1974053 to
ab093ce
Compare
Co-Authored-By: Trivikram Kamat <[email protected]>
|
@trivikr Thanks a lot! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for all xml service, the parser inserts empty
array [] when a list member doesn't exist in xml string.
It was introduced long ago: eae5b32
This change introduce a new key in metadata called
xmlNoDefaultLists. If set to true, xml parser will nottry to insert default empty array if the member doesn't
exist. This key is only applicable to rest-xml, query
protocol services.
Checklist
npm run testpassesnpm run add-change