Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where path normalization was not being disabled when signing requests directly with AwsS3V4Signer. #3601

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

millems
Copy link
Contributor

@millems millems commented Dec 8, 2022

The issue was introduced with #3534. The PR did not account for users who are using the signer directly.

…ing requests directly with AwsS3V4Signer.

The issue was introduced with #3534. The PR did not account for users who are using the signer directly.
@millems millems requested a review from a team as a code owner December 8, 2022 19:33
@millems millems enabled auto-merge (squash) December 8, 2022 19:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@millems millems merged commit 65c3aa4 into master Dec 8, 2022
@millems millems deleted the millem/fix-s3-signing-normalization branch December 9, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants