Add CRT version check at cmake and runtime #3437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
force-pushed
the
sr/crtVerCheck
branch
from
62c0054 to
ae16e27
Compare
SergeyRyabinin
force-pushed
the
sr/crtVerCheck
branch
from
ae16e27 to
fab5ff3
Compare
SergeyRyabinin
commented
May 29, 2025
| function(check_crt_version) | ||
| include(expected_crt_version) | ||
|
|
||
| file(READ "${aws-crt-cpp_SOURCE_DIR}/VERSION" CRT_SIMPLE_VERSION) |
There was a problem hiding this comment.
this variable probably won't be set if you are importing the CRT library instead of building it as a part of the SDK build, so in case of import, you want to disable the check
-DENABLE_CRT_VERSION_CHECK=OFF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
By default, git does not pull with recursive submodules pull, resulting in builds with outdated CRT submodule dependency, which in turn results in issues reported such as
#3433
Description of changes:
Add a check validating that the CRT submodule version is one set and validated by the AWS SDK team at the cmake configuration step.
Additionally, add a non-blocking logging error if CRT built-with and runtime-found versions are different.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.