Add go module support #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
======================================
Coverage 77.2% 77.2%
======================================
Files 18 18
Lines 636 636
======================================
Hits 491 491
Misses 104 104
Partials 41 41Continue to review full report at Codecov.
|
|
The first line of |
|
Good spot. I have fixed the module name. |
bmoffatt
approved these changes
May 17, 2019
| @@ -0,0 +1,10 @@ | |||
| module github.com/aws/aws-lambda-go | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #181
Initialized go modules from go deps. Modified the testRuntimeStackTrace test to compare slice of the package path instead of the raw string. as only the last 5 packages/directories are returned from frame.path.
Modified the Travis-CI job to have a job which sets GO111MODULE to on and overrides the before_install and install step to use
go mod downloadinstead ofdep ensure. All other steps are kept the same. See https://travis-ci.com/bhavikkumar/aws-lambda-go/builds/111472734