test(Mutations): additional testing for Mutations #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
had a problem deploying
to
Duvet CI
GitHub Actions
Failure
texastony
had a problem deploying
to
Duvet CI
GitHub Actions
Failure
…#753) This resolves feedback from both @seebees and @josecorella on Mutations branch. Verification failure is due to (just like in #751 ): 1. Key Store Admin's Index.dfy not proving Fresh, which has been a long standing issue with the Admin 2. In `AwsCryptographyKeyStore/test/Storage/TestGetItemsForInitializeMutation.dfy`, the test assumes `type` is in the Encryption Context. It is, but Structure.dfy does not prove that, so it must be proven else where. A .NET MPL job failed due to .NET 48 Sig V4 Auth bug.
texastony
had a problem deploying
to
Duvet CI
GitHub Actions
Failure
|
@texastony and @josecorella, I noticed you are updating the smithy model files. |
texastony
merged commit e8c3007
into
tony/mutations-pr720-response
69 of 72 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will merge this after I give @josecorella a chance to see if #751 addresses other concerns.
Verification failure is due to:
AwsCryptographyKeyStore/test/Storage/TestGetItemsForInitializeMutation.dfy, the test assumestypeis in the Encryption Context. It is, but Structure.dfy does not prove that, so it must be proven else where.A Dotnet DDB Test failed due to throttling from Nuget.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.