chore(dafny): KSA Create Branch Key with MRK keys #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
requested changes
Apr 4, 2025
Comment on lines
+101
to
+105
| // keyManagement := Some( | ||
| // Types.kms( | ||
| // Types.AwsKms( | ||
| // kmsClient := Some(kmsClient) | ||
| // ))) |
There was a problem hiding this comment.
Blocking: no commented out code unless you have a very good reason.
Suggested change
| // keyManagement := Some( | |
| // Types.kms( | |
| // Types.AwsKms( | |
| // kmsClient := Some(kmsClient) | |
| // ))) |
Comment on lines
+96
to
+97
| print "Running MRK"; | ||
|
|
There was a problem hiding this comment.
Blocking: no printing unless you have a very good reason
Suggested change
| print "Running MRK"; |
AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/test/TestAdminHV2.dfy
Outdated
Show resolved
Hide resolved
AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/test/TestAdminHV2.dfy
Outdated
Show resolved
Hide resolved
| var strategy :- expect AdminFixtures.SimpleKeyManagerStrategy(kmsClient?:=Some(kmsClient)); | ||
| var underTest :- expect AdminFixtures.DefaultAdmin(ddbClient?:=Some(ddbClient)); | ||
|
|
||
| var customEC := map[UTF8.EncodeAscii("Koda") := UTF8.EncodeAscii("Is a dog.")]; |
There was a problem hiding this comment.
Blocking: We MUST assert that this EC is present on the newly Branch Key.
Co-authored-by: Tony Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.