chore(dafny): refactor HV1 MRK test to use helper methods #1399
+153
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabhichow
reviewed
Apr 4, 2025
Comment on lines
80
to
84
| var westKeyStore :- expect KeyStoreWithOptionalClient( | ||
| kmsId := MrkArnWest, | ||
| physicalName := branchKeyStoreName, | ||
| logicalName := logicalKeyStoreName, | ||
| ddbClient? := Some(ddbClient)); |
There was a problem hiding this comment.
nit/suggestion:
Suggested change
| var westKeyStore :- expect KeyStoreWithOptionalClient( | |
| kmsId := MrkArnWest, | |
| physicalName := branchKeyStoreName, | |
| logicalName := logicalKeyStoreName, | |
| ddbClient? := Some(ddbClient)); | |
| var westKeyStore :- expect KeyStoreWithOptionalClient( | |
| kmsId := MrkArnWest, | |
| physicalName := branchKeyStoreName, | |
| logicalName := logicalKeyStoreName, | |
| ddbClient? := Some(ddbClient) | |
| ); |
There was a problem hiding this comment.
Yes, it was WIP PR (draft PR) with no formatting done and incomplete work in the test (That why CI is failing). My new commit would do this.
rishav-karanjit
changed the title
texastony
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.