Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(KeyStoreAdmin): Go support #1242

Merged
merged 3 commits into from
Jan 22, 2025
Merged

fix(KeyStoreAdmin): Go support #1242

merged 3 commits into from
Jan 22, 2025

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Jan 22, 2025 •
edited
Loading

Issue #, if available:

Description of changes:

  1. Modify the AwsCryptographicMaterialProvider Makefile for Go
  2. Re-poly Go
  3. Re-poly Python

Squash/merge commit message, if applicable:

fix(KeyStoreAdmin): Go support

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@texastony texastony requested a review from a team as a code owner January 22, 2025 19:08
@ShubhamChaturvedi7
Copy link
Contributor

I assume a part of keystoreadmin Go code is already checked-in in the base branch - and that's why there's a diff and not a completely new file?

ShubhamChaturvedi7
ShubhamChaturvedi7 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few CIs are failing, but Go looks green.

@texastony
Copy link
Contributor Author

I am OK with the 2 checks failing, but I want an approval to merge.

The failing checks are:

  • Java Examples: Dafny transpile Java is throwing a Seg Fault; I will look into that another time
  • pr-ci-net / testDotNet (AwsCryptographicMaterialProviders, 6.0.x, windows-latest) : downloading Dafny 4.9 for windows through a 403

I will work on restoring Examples outside of this, but the other .NET Windows tests all passed, giving me confidence that all is well.

@texastony texastony merged commit af0078d into mutations/mutations Jan 22, 2025
194 of 197 checks passed
@texastony texastony deleted the mutations/fix-go branch January 22, 2025 23:41
texastony added a commit that referenced this pull request Mar 14, 2025
@texastony
fix(KeyStoreAdmin): Go support (#1242)
14afbfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShubhamChaturvedi7 ShubhamChaturvedi7 ShubhamChaturvedi7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texastony @ShubhamChaturvedi7