Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(KSA): require System Key + doc polish + tests #1092

Merged
merged 9 commits into from
Dec 9, 2024
Merged

feat(KSA): require System Key + doc polish + tests #1092

merged 9 commits into from
Dec 9, 2024

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Dec 6, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  1. Polish Documentation for Mutations and the Key Store Admin
  2. Make the System Key parameter required for Initialize and Apply
  3. Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@texastony texastony requested a review from a team as a code owner December 6, 2024 23:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024

@texastony and @josecorella, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024

@texastony and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

3 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024

@texastony and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024

@texastony and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024

@texastony and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@texastony texastony changed the title Mutations/docs feat(KSA): require System Key + doc polish + tests Dec 8, 2024
josecorella
josecorella requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc nits, I would approve but if you take any of the suggestions you would have to repolymorph stuff

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

@texastony and @josecorella, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

@texastony and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

@texastony and @josecorella, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@texastony texastony merged commit a8fa8e3 into mutations/mutations Dec 9, 2024
116 checks passed
@texastony texastony deleted the mutations/docs branch December 9, 2024 19:53
texastony added a commit that referenced this pull request Dec 9, 2024
@texastony
feat(KSA): require System Key + doc polish + tests (#1092)
c808079 
- Polish Documentation for Mutations and the Key Store Admin
- Make the System Key parameter required for Initialize and Apply
- Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.
texastony added a commit that referenced this pull request Dec 11, 2024
@texastony
feat(KSA): require System Key + doc polish + tests (#1092)
ac8f938 
- Polish Documentation for Mutations and the Key Store Admin
- Make the System Key parameter required for Initialize and Apply
- Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.
texastony added a commit that referenced this pull request Dec 17, 2024
@texastony
feat(KSA): require System Key + doc polish + tests (#1092)
0fb768e 
- Polish Documentation for Mutations and the Key Store Admin
- Make the System Key parameter required for Initialize and Apply
- Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.
texastony added a commit that referenced this pull request Jan 22, 2025
@texastony
feat(KSA): require System Key + doc polish + tests (#1092)
658e526 
- Polish Documentation for Mutations and the Key Store Admin
- Make the System Key parameter required for Initialize and Apply
- Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.
texastony added a commit that referenced this pull request Jan 22, 2025
@texastony
feat(KSA): require System Key + doc polish + tests (#1092)
15f1cf0 
- Polish Documentation for Mutations and the Key Store Admin
- Make the System Key parameter required for Initialize and Apply
- Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.
texastony added a commit that referenced this pull request Mar 14, 2025
@texastony
feat(KSA): require System Key + doc polish + tests (#1092)
ad7ad5a 
- Polish Documentation for Mutations and the Key Store Admin
- Make the System Key parameter required for Initialize and Apply
- Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.
josecorella pushed a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
feat(KSA): require System Key + doc polish + tests (#1092)
a6d9366 
- Polish Documentation for Mutations and the Key Store Admin
- Make the System Key parameter required for Initialize and Apply
- Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.
josecorella pushed a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
feat(KSA): require System Key + doc polish + tests (#1092)
ed90ce8 
- Polish Documentation for Mutations and the Key Store Admin
- Make the System Key parameter required for Initialize and Apply
- Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.
josecorella pushed a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
feat(KSA): require System Key + doc polish + tests (#1092)
adc061f 
- Polish Documentation for Mutations and the Key Store Admin
- Make the System Key parameter required for Initialize and Apply
- Improve Java Example Tests to assert that all items of a Branch Key are use-able post Mutation and require the correct KMS Key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecorella josecorella josecorella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texastony @josecorella