Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(KSA): DoNotVersion for Initialize Mutation #1082

Merged
merged 6 commits into from
Dec 6, 2024
Merged

feat(KSA): DoNotVersion for Initialize Mutation #1082

merged 6 commits into from
Dec 6, 2024

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Dec 4, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  1. Implement doNotVersion behavior in Initialize Mutation
  2. Refactor Initialize, Apply, and Mutations.dfy to simplify Pre/Post conditions for Mutate

In a separate PR,
I will revise the Documentation trait for doNotVersion to explain
when it is a good idea to Version and when it is not needed.

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@texastony texastony force-pushed the mutations/mutations branch from 3515f3f to d944707 Compare December 4, 2024 23:43
@texastony texastony force-pushed the mutations/doNotVersion branch from dac9093 to cf89cfe Compare December 5, 2024 00:37
texastony
texastony commented Dec 6, 2024
View reviewed changes
Copy link
Contributor Author

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

@texastony and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@texastony texastony marked this pull request as ready for review December 6, 2024 21:43
@texastony texastony requested a review from a team as a code owner December 6, 2024 21:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

@texastony and @josecorella, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@texastony texastony merged commit 915335c into mutations/mutations Dec 6, 2024
2 checks passed
@texastony texastony deleted the mutations/doNotVersion branch December 6, 2024 22:41
texastony added a commit that referenced this pull request Dec 9, 2024
@texastony
feat(KSA): DoNotVersion for Initialize Mutation (#1082)
2e03690
texastony added a commit that referenced this pull request Dec 11, 2024
@texastony
feat(KSA): DoNotVersion for Initialize Mutation (#1082)
8b8a189
texastony added a commit that referenced this pull request Dec 17, 2024
@texastony
feat(KSA): DoNotVersion for Initialize Mutation (#1082)
15a8c9c
texastony added a commit that referenced this pull request Jan 22, 2025
@texastony
feat(KSA): DoNotVersion for Initialize Mutation (#1082)
2591bbf
texastony added a commit that referenced this pull request Jan 22, 2025
@texastony
feat(KSA): DoNotVersion for Initialize Mutation (#1082)
a914309
texastony added a commit that referenced this pull request Mar 14, 2025
@texastony
feat(KSA): DoNotVersion for Initialize Mutation (#1082)
5a9b698
josecorella pushed a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
feat(KSA): DoNotVersion for Initialize Mutation (#1082)
c1a2f1d
josecorella pushed a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
feat(KSA): DoNotVersion for Initialize Mutation (#1082)
cdb96eb
josecorella pushed a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
feat(KSA): DoNotVersion for Initialize Mutation (#1082)
793fef9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecorella josecorella josecorella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texastony @josecorella