Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(KSA): Describe Mutation bugs #1062

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix(KSA): Describe Mutation bugs #1062

merged 2 commits into from
Nov 27, 2024

Conversation

texastony
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@texastony texastony requested a review from a team as a code owner November 27, 2024 01:18
@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

texastony
texastony commented Nov 27, 2024
View reviewed changes
AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/src/DescribeMutation.dfy
Comment on lines +138 to +143
if MutationCommitment.CiphertextBlob == SystemKeyHandler.TRUST_STORAGE_UTF8_BYTES
then TRUST_STORAGE_str
else
if KMS.Types.IsValid_CiphertextType(MutationCommitment.CiphertextBlob)
then KMS_SYM_ENC_str
else UNKOWN_str
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a disappointing outcome from the Dafny formatter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what in tarnation is this formatting?

@github-actions GitHub Actions
Copy link

@texastony and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

@texastony and @josecorella, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

josecorella
josecorella approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-actions GitHub Actions
Copy link

@texastony and @josecorella, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@texastony texastony merged commit e1b9253 into mutations/mutations Nov 27, 2024
112 of 117 checks passed
@texastony texastony deleted the mutations/fix-describeMutation branch November 27, 2024 15:33
texastony added a commit that referenced this pull request Dec 2, 2024
@texastony
fix(KSA): Describe Mutation bugs (#1062)
13cf52f 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
texastony added a commit that referenced this pull request Dec 4, 2024
@texastony
fix(KSA): Describe Mutation bugs (#1062)
54c9cbf 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
texastony added a commit that referenced this pull request Dec 9, 2024
@texastony
fix(KSA): Describe Mutation bugs (#1062)
d29ca87 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
texastony added a commit that referenced this pull request Dec 11, 2024
@texastony
fix(KSA): Describe Mutation bugs (#1062)
db51e6d 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
texastony added a commit that referenced this pull request Dec 17, 2024
@texastony
fix(KSA): Describe Mutation bugs (#1062)
7c3648b 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
texastony added a commit that referenced this pull request Jan 22, 2025
@texastony
fix(KSA): Describe Mutation bugs (#1062)
823c1e6 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
texastony added a commit that referenced this pull request Jan 22, 2025
@texastony
fix(KSA): Describe Mutation bugs (#1062)
34683eb 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
texastony added a commit that referenced this pull request Mar 14, 2025
@texastony
fix(KSA): Describe Mutation bugs (#1062)
9486b19 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
josecorella pushed a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
fix(KSA): Describe Mutation bugs (#1062)
f95bee1 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
josecorella pushed a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
fix(KSA): Describe Mutation bugs (#1062)
7e18a56 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
josecorella pushed a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
fix(KSA): Describe Mutation bugs (#1062)
30120f7 
* fix(KSA): Describe Mutation bugs

* fix(Java): Always clean up test resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecorella josecorella josecorella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texastony @josecorella