Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(KSA): System Key #1021

Merged
merged 18 commits into from
Nov 25, 2024
Merged

feat(KSA): System Key #1021

merged 18 commits into from
Nov 25, 2024

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Nov 19, 2024 •
edited
Loading

Issue #, if available:

Description of changes:
Key Store Admin protects any non-cryptographic items store with this setting.
As of v?, TrustStorage is the default behavior.

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@texastony texastony changed the title WIP feat(KSA): System Key Nov 19, 2024
@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

It looks like you are adding or removing the dafny keyword {:only}.
Is this intended?

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@texastony texastony force-pushed the mutations/mutations branch 4 times, most recently from 8dc3711 to 266bf70 Compare November 20, 2024 21:01
@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

texastony
texastony commented Nov 25, 2024
View reviewed changes
AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/src/Mutations.dfy
@@ -800,7 +867,7 @@ module {:options "/functionSyntax:4" } Mutations {
return Success(queryOut);
}

method {:vcs_split_on_every_assert} ProcessBranchKeysInApplyMutation(
method {:isolate_assertions} ProcessBranchKeysInApplyMutation(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading the Dafny Ref,
it says that isolate_asserations is the per-method equivalent of the /vcsSplitOnEveryAssert.
See http://dafny.org/dafny/DafnyRef/DafnyRef#sec-isolate_assertions

When attending Dafny Proof clinics,
I was encouraged to use it.

@github-actions GitHub Actions
Copy link

@texastony and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@texastony texastony merged commit f2329d1 into mutations/decrypt-encrypt-strat Nov 25, 2024
110 of 115 checks passed
@texastony texastony deleted the mutations/systemKey branch November 25, 2024 23:11
texastony added a commit that referenced this pull request Nov 25, 2024
@texastony @josecorella
feat(KSA): System Key (#1021)
9f3e48f 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Nov 25, 2024
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
a420c76 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Nov 26, 2024
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
aedec75 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Dec 2, 2024
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
9267215 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Dec 4, 2024
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
fe7efef 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Dec 9, 2024
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
1cec54d 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Dec 11, 2024
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
ba40a53 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Dec 17, 2024
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
0643a1d 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Jan 22, 2025
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
eeabbc0 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Jan 22, 2025
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
0f0ede0 
Co-authored-by: José Corella <[email protected]>
texastony added a commit that referenced this pull request Mar 14, 2025
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
024630b 
Co-authored-by: José Corella <[email protected]>
josecorella added a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
18cb016 
Co-authored-by: José Corella <[email protected]>
josecorella added a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
5ebccbc 
Co-authored-by: José Corella <[email protected]>
josecorella added a commit that referenced this pull request Mar 31, 2025
@texastony @josecorella
feat(KSA): System Key (#1021) (#1055)
1ec7acc 
Co-authored-by: José Corella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecorella josecorella josecorella requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texastony @josecorella