Centralized leaked ENI cleanup- refactor periodic cleanup & add node termination cleaner #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…termination cleaner
yash97
reviewed
Jan 7, 2025
yash97
reviewed
Jan 7, 2025
yash97
reviewed
Jan 7, 2025
yash97
reviewed
Jan 8, 2025
yash97
reviewed
Jan 8, 2025
yash97
reviewed
Jan 8, 2025
haouc
reviewed
Jan 8, 2025
haouc
reviewed
Mar 18, 2025
haouc
approved these changes
Mar 22, 2025
yash97
added a commit
to yash97/amazon-vpc-resource-controller-k8s
that referenced
this pull request
Mar 26, 2025
…termination cleaner (aws#505) * Centralized leaked ENI cleanup- refactor periodic cleanup & add node termination cleaner * defer updating metrics * WIP commit no.3 * instance id as tag, not requeuing on node cleanup failure * not requeing on node termination cleaner failure * minor log change * adding node termination failure metric * minor test change * using paginated calls to describe network interface while eni cleanup * refactor based on comments --------- Co-authored-by: Yash Thakkar <[email protected]>
yash97
added a commit
that referenced
this pull request
Mar 26, 2025
* Centralized leaked ENI cleanup- CNINode CRD changes * Centralized leaked ENI cleanup- refactor periodic cleanup & add node termination cleaner (#505) * Centralized leaked ENI cleanup- refactor periodic cleanup & add node termination cleaner * defer updating metrics * WIP commit no.3 * instance id as tag, not requeuing on node cleanup failure * not requeing on node termination cleaner failure * minor log change * adding node termination failure metric * minor test change * using paginated calls to describe network interface while eni cleanup * refactor based on comments --------- Co-authored-by: Yash Thakkar <[email protected]> --------- Co-authored-by: sushrk <[email protected]> Co-authored-by: Sushmitha Ravikumar <[email protected]>
haouc
pushed a commit
to haouc/amazon-vpc-resource-controller-k8s
that referenced
this pull request
Apr 13, 2025
* Centralized leaked ENI cleanup- CNINode CRD changes * Centralized leaked ENI cleanup- refactor periodic cleanup & add node termination cleaner (aws#505) * Centralized leaked ENI cleanup- refactor periodic cleanup & add node termination cleaner * defer updating metrics * WIP commit no.3 * instance id as tag, not requeuing on node cleanup failure * not requeing on node termination cleaner failure * minor log change * adding node termination failure metric * minor test change * using paginated calls to describe network interface while eni cleanup * refactor based on comments --------- Co-authored-by: Yash Thakkar <[email protected]> --------- Co-authored-by: sushrk <[email protected]> Co-authored-by: Sushmitha Ravikumar <[email protected]>
haouc
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Centralized leaked ENI cleanup- CNINode CRD changes * Centralized leaked ENI cleanup- refactor periodic cleanup & add node termination cleaner (#505) * Centralized leaked ENI cleanup- refactor periodic cleanup & add node termination cleaner * defer updating metrics * WIP commit no.3 * instance id as tag, not requeuing on node cleanup failure * not requeing on node termination cleaner failure * minor log change * adding node termination failure metric * minor test change * using paginated calls to describe network interface while eni cleanup * refactor based on comments --------- Co-authored-by: Yash Thakkar <[email protected]> --------- Co-authored-by: sushrk <[email protected]> Co-authored-by: Sushmitha Ravikumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
PR 2, adding support for Centralize leaked ENI cleanup in the controller to delete leaked ENIs provisioned by the controller and VPC-CNI:
DisassociateTrunkInterface, call DisassociateTrunkInterface to remove association between branch and trunk ENI before deleting the branch ENI as per recommendation by EC2 team.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.