-
Notifications
You must be signed in to change notification settings - Fork 56
Add support to configure branch ENI cooldown period via configmap #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sushrk made some changes in the new commit. please let me know if you have comments on them. I will ask for reviews from the team. |
We allow the period configurable but force the lowest value as 30 seconds. Whenever the value is changed, the controller broadcast a node event to all nodes which ensure users the planned value being applied successfully.
Then change the value to 29 seconds which should be forced to 30 seconds although CM still has 29 seconds
|
@@ -73,6 +76,24 @@ func (r *ConfigMapReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( | |||
} | |||
} | |||
|
|||
// Check if branch ENI cooldown period is updated | |||
curCoolDownPeriod := cooldown.GetCoolDown().GetCoolDownPeriod() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this defaulted to 30s since if first time get fails what will be the value?
…s#342) * Add support to configure branch ENI cooldown period via configmap * support configurable branch ENI cooldown period * moving error check out from CM update * Fix logs and remove mutex lock in Get function * Update to go1.21.5 --------- Co-authored-by: Hao Zhou <[email protected]>
* adding govulnscheck to action (#330) * fix typo in document (#331) * Upgrade vpc-cni to v1.15.0 * Bump github.com/onsi/gomega from 1.28.0 to 1.30.0 (#338) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.28.0 to 1.30.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.28.0...v1.30.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Run go mod tidy * Upgrade golang/x/time to 0.5.0 * Bump github.com/prometheus/common from 0.44.0 to 0.45.0 (#337) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.44.0 to 0.45.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.44.0...v0.45.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update supported EC2 instances (#340) * Add support to configure branch ENI cooldown period via configmap (#342) * Add support to configure branch ENI cooldown period via configmap * support configurable branch ENI cooldown period * moving error check out from CM update * Fix logs and remove mutex lock in Get function * Update to go1.21.5 --------- Co-authored-by: Hao Zhou <[email protected]> * fix the build issue * Update cooldown period in test (#344) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Hao Zhou <[email protected]> Co-authored-by: yochien <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hao Zhou <[email protected]>
* Add support to configure branch ENI cooldown period via configmap * support configurable branch ENI cooldown period * moving error check out from CM update * Fix logs and remove mutex lock in Get function * Update to go1.21.5 --------- Co-authored-by: Hao Zhou <[email protected]>
Issue #, if available:
#306
Description of changes:
Adding support to configure the cool down period via
amazon-vpc-cni
configmap using flagbranch-eni-cooldown
, in seconds. The minimum value for the cool period is 30s, if user updates configmap to a lower value, this will be overridden and set to 30s.Testing updated in comments.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.