Skip to content

Update eventrecorder.go #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

Update eventrecorder.go #3267

merged 4 commits into from
Jun 5, 2025

Conversation

devanshpoplii
Copy link
Contributor

findMyPod function retrieves the aws-node daemonset pod and the Debug log was printing "Node found" instead, it should be "Pod found"

What type of PR is this?

Which issue does this PR fix?:

What does this PR do / Why do we need it?:

Testing done on this change:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades? Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@devanshpoplii devanshpoplii requested a review from a team as a code owner April 20, 2025 10:57
@jaydeokar
Copy link
Contributor

Thanks @devanshpoplii. Can you rebase your branch ?

findMyPod function retrieves the aws-node daemonset pod and the Debug log was printing "Node found" instead, it should be "Pod found"
Copy link
Contributor

@jaydeokar jaydeokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaydeokar jaydeokar merged commit c9d6f7b into aws:master Jun 5, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants