Refactor AllocENI #2640
Merged
Refactor AllocENI #2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
reviewed
Oct 31, 2023
jchen6585
force-pushed
the
refactor-eni
branch
from
4b2efeb to
a9a636a
Compare
jdn5126
reviewed
Nov 2, 2023
jchen6585
force-pushed
the
refactor-eni
branch
from
f9d57dc to
e01f0ff
Compare
jdn5126
approved these changes
Nov 3, 2023
jayanthvn
reviewed
Nov 6, 2023
jayanthvn
reviewed
Nov 6, 2023
|
Can you please run Ipv6, V4- PD and custom networking tests.. |
jchen6585
force-pushed
the
refactor-eni
branch
from
342bf5d to
1299296
Compare
all suites passed |
jdn5126
approved these changes
Nov 7, 2023
jayanthvn
reviewed
Nov 7, 2023
jchen6585
force-pushed
the
refactor-eni
branch
from
1299296 to
a7f7b62
Compare
jchen6585
added a commit
that referenced
this pull request
Nov 7, 2023
jchen6585
added a commit
that referenced
this pull request
Nov 7, 2023
jdn5126
pushed a commit
to jdn5126/amazon-vpc-cni-k8s
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
Reduces the number of API calls made when creating an ENI and allocating IP addresses. Combines AllocENI and AllocIpAddresses into one API call.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Manually tested against custom networking, cni, and ipv6 integration suites.
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.