Add support for Common I/O (UART, SPI and I2C) on ESP32 #1946
Conversation
|
As discussed, ESP is updating the implementation for async function. Using FreeRTOS timer is not the preferable option. |
|
/bot run checks |
|
Any updates on this PR ? |
|
@shubhamkulkarni97 @teuteuguy, As discussed originally, we were going to wait for Async, without the reliance of FreeRTOS timer. We will reverse that decision and take this as is with the hope of adding that later. @shubhamkulkarni97 I believe to get this merged, all we need to do is rebase this branch, and resolve two variables causing the build failures. The issue is caused by Please let me know if you are still willing to do this, otherwise I can create a mirror'd PR with those changes. Thanks, Carl |
|
@teuteuguy @lundinc2, will rebase PR to latest master and make it available for review soon. |
shubhamkulkarni97
force-pushed
the
feature/common_io
branch
from
f9ace34 to
3e3d179
Compare
|
Hi @lundinc2 @teuteuguy, I have updated the PR with latest changes. With this change, common-io drivers don't have any dependency on FreeRTOS timer for async implementation. There is one failure in UART test case( Moving vTaskDelay above request for Please help verify this issue. Thanks, |
|
Hi @shubhamkulkarni97, I agree this is a bug. I will update this. |
|
/bot run checks |
2 similar comments
|
/bot run checks |
|
/bot run checks |
shubhamkulkarni97
force-pushed
the
feature/common_io
branch
from
3e3d179 to
6a9dbda
Compare
|
License for newly added files brought in sync with other Espressif port files. |
shubhamkulkarni97
force-pushed
the
feature/common_io
branch
from
6a9dbda to
89a18f9
Compare
|
/bot run checks |
1 similar comment
|
/bot run checks |
| ) | ||
|
|
||
|
|
||
| target_compile_options( |
There was a problem hiding this comment.
Why did we add more compile options?
There was a problem hiding this comment.
There were a bunch of compile errors when common-io is enabled. These compile options fix those errors.
| @@ -349,6 +378,7 @@ target_link_libraries( | |||
| AFR::pkcs11 | |||
| AFR::ota_mqtt | |||
| AFR::ota_http | |||
| AFR::common_io | |||
There was a problem hiding this comment.
Does OTA need common_io?
There was a problem hiding this comment.
OTA does not need common-io and this change is added by mistake. Actually this change was added when @lundinc2 created a PR to enable common-io on esp32 in my personal fork: https://github.com/shubhamkulkarni97/amazon-freertos/pull/1/files
Sorry for overlooking this change.
Description
This PR intends to add support for UART, SPI and I2C modules in Common I/O
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.