Skip to content

feat: support enable and disable SDK #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2023
Merged

feat: support enable and disable SDK #46

merged 4 commits into from
Oct 12, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. support enable and disable SDK.

How did you test these changes?
Added test cases for timer, activity lifecycle, application lifecycle and exception handlers, which will be disabled when the SDK is disabled

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Oct 11, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane October 11, 2023 06:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c1ac692) 86.57% compared to head (229f3b6) 86.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #46      +/-   ##
============================================
+ Coverage     86.57%   86.91%   +0.33%     
- Complexity      405      414       +9     
============================================
  Files            39       39              
  Lines          1453     1467      +14     
  Branches        129      129              
============================================
+ Hits           1258     1275      +17     
+ Misses          123      121       -2     
+ Partials         72       71       -1     
Files Coverage Δ
...aws/solution/clickstream/AWSClickstreamPlugin.java 84.09% <100.00%> (+0.36%) ⬆️
...solution/clickstream/ActivityLifecycleManager.java 98.07% <100.00%> (+0.03%) ⬆️
...aws/solution/clickstream/ClickstreamAnalytics.java 80.64% <100.00%> (+6.57%) ⬆️
...olution/clickstream/client/ClickstreamManager.java 86.66% <100.00%> (+9.74%) ⬆️
...lickstream/client/ClickstreamExceptionHandler.java 62.74% <70.96%> (+2.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 3e07b5b into main Oct 12, 2023
@zxkane zxkane deleted the disable_sdk branch October 12, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants