Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prometheus version for SMHP #628

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

mhuguesaws
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mhuguesaws mhuguesaws requested review from nghtm and bluecrayon52 April 3, 2025 14:10
@mhuguesaws mhuguesaws self-assigned this Apr 4, 2025
@nghtm
Copy link
Collaborator

nghtm commented Apr 7, 2025

has this been tested? I intentionally pinned prometheus to 2.55, please see this PR:

#504

@mhuguesaws
Copy link
Contributor Author

It is tested on p5, p5en and p4de instances.

@mhuguesaws
Copy link
Contributor Author

mhuguesaws commented Apr 7, 2025

See #607 and clusters in production.
We can continue to monitor disk consumption for the next 2 weeks before making a decision.

@mhuguesaws
Copy link
Contributor Author

Agent mode was promoted to stable in Prometheus >=v3.0.0 (see)

[CHANGE] Agent mode has been promoted to stable. The feature flag agent has been removed. To run Prometheus in Agent mode, use the new --agent cmdline arg instead. #14747

Can we make a decision on this?

Copy link
Collaborator

@nghtm nghtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maxime - approved.

@nghtm nghtm merged commit 97afdd3 into main Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants