Openzfs smhp #622
Open
Openzfs smhp #622
+363
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanshanbhag
force-pushed
the
openzfs-smhp
branch
from
b7f8691 to
873f8a1
Compare
|
Force pushed changes to revert unnecessary commits from previous PR. Also need to test behavior once on cluster without OpenZFS deployment |
KeitaW
reviewed
Apr 2, 2025
1.architectures/5.sagemaker-hyperpod/LifecycleScripts/base-config/utils/fsx_ubuntu.sh
Outdated
Show resolved
Hide resolved
|
|
I will update this PR with the changes from #633 (mentioned above) to account for the race condition. |
mhuguesaws
reviewed
Apr 8, 2025
1.architectures/5.sagemaker-hyperpod/LifecycleScripts/base-config/mount_fsx_openzfs.sh
Outdated
Show resolved
Hide resolved
mhuguesaws
reviewed
Apr 8, 2025
| Description: | ||
| Creates an FSx OpenZFS file system in addition to the FSxL file system. Default is false | ||
| Type: String | ||
|
|
There was a problem hiding this comment.
IOPS chould be configurable as well.
DiskIopsConfiguration:
Iops:
Mode:
… deployment" This reverts commit b7f8691.
amanshanbhag
force-pushed
the
openzfs-smhp
branch
from
282a176 to
feb876a
Compare
amanshanbhag
force-pushed
the
openzfs-smhp
branch
from
d277d76 to
019b2fd
Compare
|
@mhuguesaws addressed all your comments. @KeitaW if you'd like to, you should be able to test one more time before merged (already tested on local env) |
…fig/mount_fsx_openzfs.sh Co-authored-by: mhuguesaws <[email protected]>
mhuguesaws
reviewed
Apr 9, 2025
| echo "$FSX_OPENZFS_DNS_NAME:/fsx $OPENZFS_MOUNT_POINT nfs nfsvers=4.2,_netdev 0 0" | tee -a /etc/fstab | ||
| } | ||
|
|
||
| mount_fs() { |
There was a problem hiding this comment.
Some much duplication. Once you add the entry in fstab, you should just do mount -a that will mount volume from fstab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available: #601 *
Description of changes:
Adding in FSx OpenZFS to be an optional home directory for SMHP SLURM users. Changes included in CF stack template, automate cluster script, and lifecycle scripts.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.