Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update megatron lm testcase #537

Closed
wants to merge 1 commit into from
Closed

Conversation

KeitaW
Copy link
Collaborator

@KeitaW KeitaW commented Jan 30, 2025

This PR introduces following changes:

  • Update container image to the latest
  • Separate slurm and kubernetes instructions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@KeitaW KeitaW force-pushed the update-megatron-lm-testcase branch from 3706f08 to 7b1a963 Compare February 5, 2025 02:21
@KeitaW KeitaW self-assigned this Feb 5, 2025
@KeitaW KeitaW added the enhancement New feature or request label Feb 6, 2025
@KeitaW KeitaW force-pushed the update-megatron-lm-testcase branch 3 times, most recently from fb1cba3 to ff432dd Compare February 8, 2025 02:09
@KeitaW KeitaW marked this pull request as ready for review February 8, 2025 02:10
@KeitaW KeitaW force-pushed the update-megatron-lm-testcase branch 4 times, most recently from d9f3b76 to 3994278 Compare February 8, 2025 02:20
reorganize

update Megatron-LM test case

update kubernetes README

update test

add readme for gpt3 pretraining on EKS

update

update make file

add --tp-comm-overlap

update dockerfile

update container

update README

update

move makefile

update

update
@KeitaW KeitaW force-pushed the update-megatron-lm-testcase branch from 3994278 to 642fb43 Compare February 8, 2025 02:30
Copy link
Contributor

@mhuguesaws mhuguesaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reorganizing this.
I think it will be better to have Model > Orchestrator. We tend to look for model and then orchestrator rather than the opposite.
What do you think?

@KeitaW
Copy link
Collaborator Author

KeitaW commented Feb 20, 2025

That works for me. Will update the PR shortly...

@KeitaW KeitaW mentioned this pull request Mar 4, 2025
@KeitaW KeitaW closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants