Skip to content

chore: Revert Common copy and setup #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Apr 8, 2025

Please provide the issue number

Issue number: #839

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2025
@github-actions github-actions bot added the internal Maintenance changes label Apr 8, 2025
@boring-cyborg boring-cyborg bot added area/idempotency area/logging Core logging utility area/metrics Core metrics utility area/parameters area/tracing Core tracing utility tests labels Apr 8, 2025
Copy link

sonarqubecloud bot commented Apr 8, 2025

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.82%. Comparing base (71939e8) to head (a49ee2b).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #844      +/-   ##
===========================================
- Coverage    75.88%   75.82%   -0.07%     
===========================================
  Files          233      233              
  Lines         9422     9422              
  Branches      1031     1031              
===========================================
- Hits          7150     7144       -6     
- Misses        1953     1958       +5     
- Partials       319      320       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hjgraca hjgraca merged commit 259d502 into aws-powertools:develop Apr 8, 2025
7 of 8 checks passed
@hjgraca hjgraca deleted the fix/revert-common-setup branch April 8, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/idempotency area/logging Core logging utility area/metrics Core metrics utility area/parameters area/tracing Core tracing utility internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants