chore: Fix Console output when running on Top Level Statements #835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #783
Summary
Changes
This pull request introduces changes to the
SystemWrapper
class to support test mode functionality and adds corresponding unit tests. The most important changes include adding test mode fields, modifying the logging methods to handle test mode, and adding new private methods to manage console output. Additionally, new unit tests are added to verify the behavior in both production and test modes.Changes to
SystemWrapper
class:_inTestMode
,_testOutputStream
, and_outputResetPerformed
fields to support test mode and track console output state.Log
andLogLine
methods to write to_testOutputStream
in test mode and ensure console output is reset once in production mode.SetOut
method to enable test mode by setting_testOutputStream
and_inTestMode
flag.EnsureConsoleOutputOnce
,ResetConsoleOutput
,ClearOutputResetFlag
, andResetTestMode
methods to manage console output and test mode state.New unit tests:
SystemWrapperTests
class with tests to verify logging behavior in both production and test modes, and to ensure proper state management of console output.User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.