fix(logging): check if ILambdaContext is valid in LoggingLambdaContext.Extract

[gregsinclair42]

Issue number: 792

Summary

Check if the ILambdaContext is valid before extracting and using it. Powertools Logging already checks if the ILambdaContext is null, but only if it is the FIRST parameter, not the second or third, etc.

Changes

• added more checks to determine if the argument is castable to ILambdaContext and not null.
• added unit test

User experience

Previously, unit tests could be hard to write if a method we call had the [Logging] attribute on it, because then we had to ensure the LambdaContext was set and valid. Now we don't have to worry about the lambda context and can just focus on the code.

This would occur if there was a method like:

[Logging(LogEvent = true)]
public async Task<APIGatewayProxyResponse> Handle(APIGatewayProxyRequest request, ILambdaContext context)
{ 
// handle stuff
}

// then if it was called by a unit test like 
[Fact]
void Task Oops()
{
    // test setup...
    Assert.NotNull(await myHandler.Handle(apiGatewayProxyRequest, null)); // this throws an exception
}

Checklist

Please leave checklist items unchecked if they do not apply to your change.

• Meets tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change? **NO**

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[boring-cyborg]

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #dotnet channel on our Powertools for AWS Lambda Discord: Invite link

[hjgraca]

Thank you! Looks great!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.04%. Comparing base (08efcb2) to head (1dc566e).
Report is 11 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #791      +/-   ##
===========================================
- Coverage    74.04%   74.04%   -0.01%     
===========================================
  Files          210      210              
  Lines         8404     8402       -2     
  Branches       910      910              
===========================================
- Hits          6223     6221       -2     
  Misses        1883     1883              
  Partials       298      298              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hjgraca]

Thank you! GTM

[gregsinclair42]

Thank you! GTM

Thanks for the quick review @hjgraca. Can you let me know what is the expected timeline to get it merged and released into a new nuget package? Much appreciated.

[hjgraca]

Thank you! GTM

Thanks for the quick review @hjgraca. Can you let me know what is the expected timeline to get it merged and released into a new nuget package? Much appreciated.

Merged, right now :)
We release on Tuesdays, the next release date is Tuesday 11th March. Do you need it before that date?

[hjgraca]

Did you intend to close the pull request or was a mistake?

[gregsinclair42]

Did you intend to close the pull request or was a mistake?

sorry, my mistake! i meant to close a comment. Thanks for re-opening.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gregsinclair42]

Thank you! GTM

Thanks for the quick review @hjgraca. Can you let me know what is the expected timeline to get it merged and released into a new nuget package? Much appreciated.

Merged, right now :) We release on Tuesdays, the next release date is Tuesday 11th March. Do you need it before that date?

These buttons are misleading :)

We can wait until March 11th.

[boring-cyborg]

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!